propagate current redis cluster state to redisfailver crd #667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation
If Redisfailover cluster is not in healthy/ready state the state is not propagated. Therefore there is no way how to propagate the redis status to the user.
Showcase from ArgoCD where rfr POD is not running but redisfailover crd is in healthy state. Broken redisfailover cluster is not propagated:
Propose implementation
Add 'status' section in RedisFailover CRD. If Redisfailover cluster in not in OK state, the redisfailover crd status is updated. Therefore it is possible to make healthcheck above whole Redisfailover cluster.
E.g. in ArgoCD the custome health check might look like this:
as shown in following printscreen, if redisfailover is broken whole crd resource and application is mark as unhealthy