Merge pull request #44 from sportsdataverse/pwhl_scraper

Fixing bug introduced in previous PR
sportsdataverse · Mar 1, 2024 · 5b93d02 · 5b93d02
2 parents 2959468 + 07fbd93
commit 5b93d02
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/R/pwhl_team_roster.R b/R/pwhl_team_roster.R
@@ -18,7 +18,7 @@
 pwhl_team_roster <- function(team, season, regular = TRUE) {
 
   # team_id <- 1 # will need the team/season look ups
-  team_id <- pwhl_teams() %>%
+  team_id <- fastRhockey::pwhl_teams() %>%
     dplyr::filter(.data$team_label == team)
   # season_id <- 2 # 1 is regular season, 2 is pre-season
   if (regular) {
@@ -102,6 +102,8 @@ pwhl_team_roster <- function(team, season, regular = TRUE) {
 
           }
 
+        } else {
+          next
         }
 
       }
@@ -115,7 +117,7 @@ pwhl_team_roster <- function(team, season, regular = TRUE) {
           season = season,
           player_id = as.numeric(player_id),
           team_id = as.numeric(team_id$team_id),
-          team = team_id$team_name
+          team = team
         ) %>%
         dplyr::relocate("team_id", .after = player_id) %>%
         dplyr::relocate("season", .after = team_id)