Avoid host validate when is omitted #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 3, 2019
houndci-bot
reviewed
Dec 3, 2019
dentarg
reviewed
Dec 3, 2019
dentarg
reviewed
Dec 3, 2019
dentarg
reviewed
Dec 3, 2019
| @@ -74,6 +74,9 @@ module CharacterClasses | |||
| "ldap" => 389, | |||
| "prospero" => 1525 | |||
| } | |||
| ## | |||
| # @@avoid_host_omitted is to avoid host validate when is set to be omitted | |||
| @@avoid_host_omitted = true | |||
There was a problem hiding this comment.
Because, when the method "omit" is called, the host is nullified, and then call the method "validate" the error InvalidURIError, "Hostname not supplied:. So I don't like this approach to use @@ in this case, but I don't see any solutions to solve this problem without a huge refactory. Do you have any idea?
CzystyEtyl
approved these changes
Jan 21, 2022
rexingQ
reviewed
May 24, 2022
| @@ -1033,6 +1033,19 @@ def to_s | |||
| end | |||
| end | |||
rexingQ
approved these changes
May 24, 2022
rexingQ
approved these changes
May 24, 2022
rexingQ
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #363