Adding demo project #8

sc-nick · 2021-05-10T07:38:59Z

No description provided.

dinitri · 2021-05-10T09:36:19Z

demo/config.xml

+    <plugin name="cordova-plugin-whitelist" spec="1.3.3" />
+    <plugin name="cordova-plugin-statusbar" spec="2.4.2" />
+    <plugin name="cordova-plugin-device" spec="2.0.2" />
+    <plugin name="cordova-plugin-splashscreen" spec="5.0.2" />
+    <plugin name="cordova-plugin-ionic-webview" spec="^4.0.0" />
+    <plugin name="cordova-plugin-ionic-keyboard" spec="^2.0.5" />


plugin tag not used now with new cordova version

Suggested change

<plugin name="cordova-plugin-whitelist" spec="1.3.3" />

<plugin name="cordova-plugin-statusbar" spec="2.4.2" />

<plugin name="cordova-plugin-device" spec="2.0.2" />

<plugin name="cordova-plugin-splashscreen" spec="5.0.2" />

<plugin name="cordova-plugin-ionic-webview" spec="^4.0.0" />

<plugin name="cordova-plugin-ionic-keyboard" spec="^2.0.5" />

dinitri · 2021-05-10T09:37:45Z

demo/resources/README.md

+These are Cordova resources. You can replace icon.png and splash.png and run
+`ionic cordova resources` to generate custom icons and splash screens for your
+app. See `ionic cordova resources --help` for details.
+
+Cordova reference documentation:
+
+- Icons: https://cordova.apache.org/docs/en/latest/config_ref/images.html
+- Splash Screens: https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-splashscreen/


A little description on how to build and launch app

dinitri · 2021-05-10T09:43:25Z

demo/src/app/home/home.page.ts

+      outputType: 1,
+    };
+
+    window.imagePicker.getPictures(


we can try to declare imagePicker var as any at the top and use it directly instead of using window

dinitri · 2021-05-10T09:44:08Z

demo/src/app/home/home.page.ts

+        this.images = [];
+        this.images = [];


duplicate assignment

Suggested change

this.images = [];

this.images = [];

this.images = [];

dinitri · 2021-05-10T10:21:05Z

demo/src/app/home/home.page.html

+    <ion-grid>
+      <ion-row *ngFor="let row of grid">
+        <ion-col width-33 *ngFor="let img of row">
+          <div class="img-container" *ngIf="img">
+            <div class="close-btn">
+              <ion-icon
+                name="trash-outline"
+                (click)="removeImage(img)"
+              ></ion-icon>
+            </div>
+            <img [src]="img | safe" height="150" />
+          </div>
+        </ion-col>
+      </ion-row>
+    </ion-grid>


I think we can simplify the grid display using a flat array of urls and property size=4 to get 3 columns
In home.page.ts

images = [ "path", "path", "path", "path", . . etc ];

in home.page.html

<ion-grid> <ion-row> <ion-col *ngFor="let url of images" ion-col [size="4"]> <div class="img-container"> <div class="close-btn"> <ion-icon name="trash-outline" (click)="removeImage(img)" ></ion-icon> </div> <img [src]="url | safe" height="150" /> </ion-col> </ion-row> </ion-grid>

src/android/ImagePicker.java

Co-authored-by: dinitri-ragoo <[email protected]>

azharbeebeejaun · 2021-05-17T11:25:58Z

demo/.editorconfig

@@ -0,0 +1,16 @@
+# Editor configuration, see https://editorconfig.org


Fichier à supprimer.

azharbeebeejaun · 2021-05-17T11:29:37Z

demo/config.xml

+    <name>demo</name>
+    <description>An awesome Ionic/Cordova app.</description>
+    <author email="[email protected]" href="http://ionicframework.com/">Ionic Framework Team</author>


Suggested change

<name>demo</name>

<description>An awesome Ionic/Cordova app.</description>

<author email="hi@ionicframework.com" href="http://ionicframework.com/">Ionic Framework Team</author>

<name>ImagePicker demo</name>

<description>Demo app for image picker cordova app.</description>

<author email="nick.andrianaharimalala@sc-mauritius.com" href="http://spoonconsulting.com/">Spoon Consulting Ltd</author>

azharbeebeejaun · 2021-05-17T11:32:22Z

demo/ionic.config.json

@@ -0,0 +1,7 @@
+{
+  "name": "demo",


Suggested change

"name": "demo",

"name": "ImagePicker demo",

azharbeebeejaun · 2021-05-17T11:32:59Z

demo/package.json

@@ -0,0 +1,90 @@
+{


package-lock.json à supprimer.

azharbeebeejaun · 2021-05-17T11:33:13Z

demo/package.json

@@ -0,0 +1,90 @@
+{
+  "name": "demo",


Suggested change

"name": "demo",

"name": "ImagePicker demo",

azharbeebeejaun · 2021-05-17T11:35:03Z

demo/package.json

+  "cordova": {
+    "plugins": {
+      "@spoonconsulting/cordova-plugin-telerik-imagepicker": {
+        "PHOTO_LIBRARY_USAGE_DESCRIPTION": "DemoIPicker require access to photo library to choose from existing photos."


Suggested change

"PHOTO_LIBRARY_USAGE_DESCRIPTION": "DemoIPicker require access to photo library to choose from existing photos."

"PHOTO_LIBRARY_USAGE_DESCRIPTION": "ImagePicker demo require access to photo library to choose from existing photos."

azharbeebeejaun · 2021-05-17T11:37:05Z

demo/src/app/app.component.spec.ts

+    const app = fixture.debugElement.componentInstance;
+    expect(app).toBeTruthy();
+  });
+  // TODO: add more tests!


Idem, je ne pense pas qu'on voudrait des tests sur l'app demo.

azharbeebeejaun · 2021-05-17T11:38:54Z

demo/src/app/home/home.page.html

+    <input type="button" value="Open gallery" (click)="openGallery()" />
+    <ion-grid>
+      <ion-row>
+        <ion-col *ngFor="let url of images" ion-col size="4">


Suggested change

<ion-col *ngFor="let url of images" ion-col size="4">

<ion-col *ngFor="let url of images" size="4">

Besoin de ça ?

azharbeebeejaun · 2021-05-17T11:41:04Z

demo/src/app/home/home.page.ts

+    );
+  }
+
+  hasReadPermission() {


C'est utilisé où ?

dsl, c reglé

azharbeebeejaun · 2021-05-17T11:58:22Z

demo/e2e/src/app.e2e-spec.ts

@@ -0,0 +1,14 @@
+import { AppPage } from './app.po';


On n'a pas besoin de tests sur l'app demo. Tu peux supprimer les fichiers pour les tests. @ombr on est d'accord ?

…-plugin-telerik-imagepicker into add-demo

sc-nick · 2021-05-17T12:33:02Z

@azharbeebeejaun je pense que c bon

sc-nick added 2 commits May 10, 2021 10:33

Demo added

b1a4ac6

Reset ImagePicker

11141ba

sc-nick requested review from azharbeebeejaun and dinitri May 10, 2021 08:00

dinitri requested changes May 10, 2021

View reviewed changes

sc-nick and others added 3 commits May 12, 2021 12:17

Refactoring

42d07be

Refactor

bae813a

Update src/android/ImagePicker.java

40b1fbe

Co-authored-by: dinitri-ragoo <[email protected]>

azharbeebeejaun reviewed May 17, 2021

View reviewed changes

azharbeebeejaun requested a review from ombr May 17, 2021 11:59

azharbeebeejaun assigned sc-nick May 17, 2021

sc-nick added 2 commits May 17, 2021 15:26

Refactor

80541d5

Merge branch 'add-demo' of https://github.com/spoonconsulting/cordova…

a7a9752

…-plugin-telerik-imagepicker into add-demo

Update homepage

d2d1ed9

ombr requested a review from YushraJewon May 17, 2021 16:48

ombr removed their request for review May 27, 2021 14:25

YushraJewon removed their request for review May 30, 2022 12:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding demo project #8

Adding demo project #8

sc-nick commented May 10, 2021

dinitri May 10, 2021

sc-nick May 14, 2021

dinitri May 10, 2021 •

edited

Loading

sc-nick May 14, 2021

dinitri May 10, 2021

sc-nick May 14, 2021

dinitri May 10, 2021

sc-nick May 14, 2021

dinitri May 10, 2021

sc-nick May 14, 2021

azharbeebeejaun May 17, 2021

azharbeebeejaun May 17, 2021

azharbeebeejaun May 17, 2021

azharbeebeejaun May 17, 2021

azharbeebeejaun May 17, 2021

azharbeebeejaun May 17, 2021

azharbeebeejaun May 17, 2021

azharbeebeejaun May 17, 2021

sc-nick May 17, 2021

azharbeebeejaun May 17, 2021

sc-nick May 17, 2021

azharbeebeejaun May 17, 2021

sc-nick May 17, 2021

sc-nick commented May 17, 2021

		@@ -0,0 +1,16 @@
		# Editor configuration, see https://editorconfig.org

-    <name>demo</name>
-    <description>An awesome Ionic/Cordova app.</description>
-    <author email="hi@ionicframework.com" href="http://ionicframework.com/">Ionic Framework Team</author>
+    <name>ImagePicker demo</name>
+    <description>Demo app for image picker cordova app.</description>
+    <author email="nick.andrianaharimalala@sc-mauritius.com" href="http://spoonconsulting.com/">Spoon Consulting Ltd</author>

	"PHOTO_LIBRARY_USAGE_DESCRIPTION": "DemoIPicker require access to photo library to choose from existing photos."
	"PHOTO_LIBRARY_USAGE_DESCRIPTION": "ImagePicker demo require access to photo library to choose from existing photos."

	<ion-col *ngFor="let url of images" ion-col size="4">
	<ion-col *ngFor="let url of images" size="4">

Adding demo project #8

Are you sure you want to change the base?

Adding demo project #8

Conversation

sc-nick commented May 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dinitri May 10, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sc-nick commented May 17, 2021

dinitri May 10, 2021 •

edited

Loading