Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nterl0k - RMM Must Die - Update #3030

Merged
merged 23 commits into from
Jul 26, 2024

Conversation

nterl0k
Copy link
Contributor

@nterl0k nterl0k commented Jul 9, 2024

Details

Added a global exception lookup (wildcards accepted) with filtering macro that interacts with the asset and identity model to provide a more uniform/easy way to suppress false positives/known usage of RMM tools in an environment. This content allows users to have one place to drop permanent (or temporary) allowances to the RMM content.

The lookup/macro also provides an optional date & days TTL for any items added.

This works in addition to the standard ESCU "filter" macros to provide a course and fine grain level of tuning for the content.

Exception List
image

Feilds added to existing rules by macro
image

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.

@ljstella ljstella added this to the v4.37.0 milestone Jul 25, 2024
@ljstella
Copy link
Contributor

Testing is failing because the macro remote_access_software_usage_exception_filter calls a lookup asset_lookup_by_str- that's part of ES and not present in the testing containers. Checking internally to see how we want to handle testing this.

ljstella
ljstella previously approved these changes Jul 25, 2024
Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now passing all testing and should be good to go!

Thanks again for your awesome contributions.

@ljstella
Copy link
Contributor

Update after discussion w/ @patel-bhavin:

  • The remote_access_software_exceptions lookup was converted to a kvstore based lookup in order to ensure customer modifications are preserved in future updates of the app instead of being overwritten with the example data.
  • The remote_access_software_exception_filter macro was renamed, removing the _filter in order to more easily distinguish it from regular _filter macros that do not come pre-filled.
  • Because we switched to a kvstore based lookup from a CSV, we lost the example data that was pre-filling the exceptions lookup. Because of this, additional information was added to the how_to_implement sections of each detection that utilizes it. That doesn't feel quite as good but is . If you have a blog that references how to use it, adding it to the references section would be the easiest way to get the same if not more detail into the proximity of usage.

That stuff aside, this is now passing all checks, and looks to be good to merge now!

@ljstella ljstella self-requested a review July 26, 2024 19:22
@nterl0k
Copy link
Contributor Author

nterl0k commented Jul 26, 2024 via email

@patel-bhavin
Copy link
Contributor

Thank you @ljstella and @nterl0k ! Snazzy updates in here :)

@patel-bhavin patel-bhavin merged commit 2a2182e into splunk:develop Jul 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants