-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.13 support #302
base: main
Are you sure you want to change the base?
Python 3.13 support #302
Conversation
Current status: I think we're waiting on Python 3.13 to land in actions/python-versions so that actions/setup-python can use it. This also pushes us up close to 50 jobs- which is a lot! I think we can pare this back a bit too- at the moment, there are no macOS 15 runners, so macos-14 and macos-latest are duplicates currently. Additionally, I think we have some duplication between |
Update: Waiting on actions/python-versions#312 to merge |
Update: python-version and setup-python are working now, python 3.13 installs. Currently blocked on: Looks like pygit2 on |
Tweaked the matrices and OS:
Edit: With these changes to the tests being run, the rules for expected checks need to be revisited. |
/Users/lstella/ThreatResearch/github/contentctl/.venv/lib/python3.13/site-packages/splunklib/client.py:772: SyntaxWarning: invalid escape sequence '\/'
versionSearch = re.search('(?:servicesNS\/[^/]+\/[^/]+|services)\/[^/]+\/v(\d+)\/', path)
Traceback (most recent call last):
File "/Users/lstella/ThreatResearch/github/contentctl/.venv/bin/contentctl", line 6, in <module>
sys.exit(main())
~~~~^^
File "/Users/lstella/ThreatResearch/github/contentctl/contentctl/contentctl.py", line 166, in main
models = tyro.extras.subcommand_type_from_defaults(
{
...<10 lines>...
}
)
File "/Users/lstella/ThreatResearch/github/contentctl/.venv/lib/python3.13/site-packages/tyro/extras/_base_configs.py", line 134, in subcommand_type_from_defaults
tuple(
~~~~~^
Annotated.__class_getitem__( # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...<10 lines>...
for k, v in defaults.items()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "/Users/lstella/ThreatResearch/github/contentctl/.venv/lib/python3.13/site-packages/tyro/extras/_base_configs.py", line 135, in <genexpr>
Annotated.__class_getitem__( # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/Cellar/[email protected]/3.13.0_1/Frameworks/Python.framework/Versions/3.13/lib/python3.13/typing.py", line 548, in __getattr__
raise AttributeError(item)
AttributeError: __class_getitem__ |
Pending on brentyi/tyro#200 to add Python 3.13 support. Confirmed current error appears to be addressed in the changes. |
Tyro 0.9.0 was released (This closes #328) but was yanked due to an issue. Once its re-released, this should be good to go. |
Tyro 0.9.1 introduced a whole new issue for us: brentyi/tyro#203 |
Re: Tyro 0.9.1- current issues are caused by the |
Python 3.13.0 was released today: https://www.python.org/downloads/release/python-3130/
I do not think there's any python 3.13.0 specific features we want or need, but I would like to test to confirm
contentctl
functions as expected with 3.13