Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid extra fields in YMLs #208

Open
wants to merge 3 commits into
base: release_v4.2.0
Choose a base branch
from
Open

Forbid extra fields in YMLs #208

wants to merge 3 commits into from

Conversation

pyth0n1c
Copy link
Contributor

@pyth0n1c pyth0n1c commented Jul 27, 2024 •
edited
Loading

Add an extra, missing field to the lookup.py model called max_matches that was accidentally dropped. set extra='forbid' for SecurityContentObject

This PR is on hold pending significant, structural changes to Detection YMLs with respect to Risk Based Alterting (RBA) content:
#263

@pyth0n1c
Add an extra, missing field to the lookup.py model called max_matches…
60b6e1b 
… that was accidentally dropped. set extra='forbid' for SecurityContentObject
@pyth0n1c pyth0n1c mentioned this pull request Jul 27, 2024
Open
@pyth0n1c
Copy link
Contributor Author

pyth0n1c commented Jul 27, 2024 •
edited
Loading

Note that the groups and context fields were temporarily added to the detection_tags object and will require some discussion. We may also need to update the contentctl new command to make sure no erroneous fields are written, like risk_score.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PENDING OTHER CHANGES
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pyth0n1c