Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration from httplib2 to requests library #115

Merged
3 commits merged into from
Jan 18, 2022

Conversation

sfultariya-crest
Copy link
Contributor

Changes:

  • feat: migration from httplib2 to requests library
  • BREAKING CHANGE: the 'build_http_connection function of alert_actions_base.py has been deprecated. Users can use 'send_http_request' function of the same class or use 'requests.request' function.

pyproject.toml Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jan 5, 2022

@sfultariya-crest Can you please create an issue, similar to splunk/addonfactory-ta-library-python#50 in this repository, so all users will know what was changed within this breaking change and how to deal with it?

@sfultariya-crest sfultariya-crest linked an issue Jan 6, 2022 that may be closed by this pull request
@sfultariya-crest
Copy link
Contributor Author

@sfultariya-crest Can you please create an issue, similar to splunk/addonfactory-ta-library-python#50 in this repository, so all users will know what was changed within this breaking change and how to deal with it?

I have created issue #117. Please let me know your suggestion.

@sfultariya-crest sfultariya-crest requested a review from a user January 7, 2022 13:30
@ghost ghost merged commit 55a7f4c into main Jan 18, 2022
@ghost ghost deleted the feature-migrate-to-requests branch January 18, 2022 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

httplib2 to requests migration
3 participants