Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

varonissaas: update logo files - update logo images for application #6

Merged

Conversation

vkorenkov-varonis
Copy link
Contributor

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • [n/a] Testing of all the changes has been performed (for bug fixes / features)
  • [n/a] The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe): logos

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • update logo images for application

@splunk-soar-connectors-bot
Copy link
Collaborator

Thank you for your submission! We have a total of 20 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Static Tests results for commit a8eff69 - https://drive.google.com/file/d/1ogCHlbzwWGH1fdPYX542amK8NwwvIhIb/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Compile Tests results for commit a8eff69 - https://drive.google.com/file/d/13Qp1G2bIDgYaA1Waonv0VvQcNz8Jl8gc/view?usp=drivesdk

@vkorenkov-varonis
Copy link
Contributor Author

vkorenkov-varonis commented Oct 31, 2024

Please, can you tell how to change a logo image in the marketplace. The logo in marketplace should be squared and doesn't contain the name of the company. I have this logo, but I did not find the way how to configure settings to use it in the marketplace.

@mmomin-crest
Copy link
Contributor

Hi @vkorenkov-varonis
Logo image in the market place for the SOAR Apps is the SVG file of this connector itself. The logo in the market place will be replaced by the SVG file that you have updated here after the app is released.

Splunkbase uses SVG file for the light mode(in this case - logo_varonissaas.svg). Splunkbase itself has default dark theme. Thus, black coloured logos are not visible on the Splunk base.

Please note - There are Two apps, 'Varonis SaaS' and 'Varonis SaaS for SOAR'. You can only change the logo of the later one(SOAR App) from this connector.

Let us know if you have any other queries.

@vkorenkov-varonis
Copy link
Contributor Author

vkorenkov-varonis commented Nov 11, 2024

Hi @mmomin-crest,
The question is: can I use third one image, to be displayed in marketplace? The reason is that we have rectangular logo for Splunk App, and we have square logo for marketplace, because on the marketplace side rectangular log looks pretty badly. Is it possible to use additional image for marketplace?

@mmomin-crest
Copy link
Contributor

@vkorenkov-varonis
I asked around. And there is no way to display a different logo in the Market place.

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest ishans-crest merged commit f18f511 into splunk-soar-connectors:next Nov 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants