Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varonissaas : New App - application for fetching events and alerts from Varonis SaaS to Splunk SOAR #1

Merged

Conversation

vkorenkov-varonis
Copy link
Contributor

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • action get alerts - Get alerts from Varonis SaaS
  • action update alert status - Update Varonis alert status command
  • action close alert - Close Varonis alert command
  • action get alerted events - Get alerted events from Varonis SaaS
  • functionality to ingest data from Varonis SaaS

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)


Thanks for contributing!

@splunk-soar-connectors-bot
Copy link
Collaborator

Thank you for your submission! We have a total of 21 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Static Tests results for commit 5ff7ba4 - https://drive.google.com/file/d/1WtwrbKIO7XCtZODfA4w_sMDfC4dybodu/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Compile Tests results for commit 5ff7ba4 - https://drive.google.com/file/d/19Ko6k-qz7EW-XY2GekP9RKP3SmwJuTxY/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Static Tests results for commit a043283 - https://drive.google.com/file/d/1t_8bL6BxTzsNV3oCRpYqvpsMIp0AHHCy/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Compile Tests results for commit a043283 - https://drive.google.com/file/d/1mSan8ZEfYnphCLeLC8KbZW0CcfqjRSgv/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@vkorenkov-varonis
Copy link
Contributor Author

Hi @stutib-crest, can you provide me information, approximately when pull request can be approved? I just need to notify my management.

@vdobrotskyi-varonis
Copy link

Hi @tonyc-phantom @stutib-crest @alexa-phantom do you have any ETA for approving this PR? Thanks

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Static Tests results for commit 477c78f - https://drive.google.com/file/d/1N3dzYId-D2vEeWly01CS60KSuIawK0Ou/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Compile Tests results for commit 477c78f - https://drive.google.com/file/d/1bs2Om33-FV9Px868DHXfa58-5XbDAZS8/view?usp=drivesdk

@stutib-crest
Copy link
Contributor

Hi @vkorenkov-varonis,
We observed that in connector file while processing the empty response in line 143, we observed that even in case when r.text exists we are processing it as empty response. Is this an expected behaviour? As even if there will be text in response we will be returning that we got an empty reponse.

@vkorenkov-varonis
Copy link
Contributor Author

Hi @vkorenkov-varonis, we observed that in connector file while processing the empty response in line 143, we observed that even in case when r.text exists we are processing it as empty response. Is this an expected behavior? As even if there will be text in response, we will be returning that we got an empty response.

Hi @stutib-crest,
In short, it's expected behavior.

Explanation:

  1. This is code generated by phantom, when the application was initialized.
  2. There is an explanation in the comment, that if we receive text in response, that we can't parse, we observe it as an empty response
  3. In normal case it shouldn't be called ever

@ishans-crest ishans-crest merged commit 0020e12 into splunk-soar-connectors:next Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants