Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAPP-32426] SMTP: Bugfix - Removing hardcoded paths to phantom home #22

Merged
merged 7 commits into from
Mar 6, 2024

Conversation

bbielinski-splunk
Copy link
Contributor

@bbielinski-splunk bbielinski-splunk commented Dec 5, 2023

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Removing hardcoded paths to phantom home [PAPP-32426]

What is the current behavior? (OPTIONAL)

n/a

What is the new behavior? (OPTIONAL)

n/a

Other information (OPTIONAL)

n/a

Pay close attention to (OPTIONAL)

n/a

Screenshots (if relevant)

n/a


Thanks for contributing!

@bbielinski-splunk bbielinski-splunk changed the title PAPP-32426: Removing hardcoded paths to phantom home SMTP: Bugfix - Removing hardcoded paths to phantom home Dec 5, 2023
@bbielinski-splunk bbielinski-splunk changed the title SMTP: Bugfix - Removing hardcoded paths to phantom home [PAPP-32426] SMTP: Bugfix - Removing hardcoded paths to phantom home Dec 8, 2023
@bbielinski-splunk bbielinski-splunk marked this pull request as ready for review December 11, 2023 12:35
smtp.json Outdated Show resolved Hide resolved
smtp_connector.py Outdated Show resolved Hide resolved
@bbielinski-splunk bbielinski-splunk merged commit 9bf0fea into next Mar 6, 2024
9 checks passed
@bbielinski-splunk bbielinski-splunk deleted the bbielinski/PAPP-32426 branch March 6, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants