Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring delete_file action #24

Closed
wants to merge 6 commits into from
Closed

Refactoring delete_file action #24

wants to merge 6 commits into from

Conversation

JakePeralta7
Copy link

Made some changes in delete_file:

  • Removed usage of aliases to proper powershell syntax
  • Added support of deleting directories recursively by adding recurse input

Adding documentation for the delete_file action
@splunk-soar-connectors-bot
Copy link
Collaborator

Thank you for your submission! We have a total of 21 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest
Copy link
Contributor

Hi @JakePeralta7
We can see there are two Application JSON files in the PR. winrm.json(the original one) and cyberwindowsremotemanagement.json which was added in your commit. There is supposed to be only one JSON file in the project folder. Is the second one added by mistake or what is the reason behind adding the new one?

@ishans-crest
Copy link
Contributor

Hi @JakePeralta7
Could you please check into the issue?

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest
Copy link
Contributor

Hi @JakePeralta7
Can you give us details regarding the closure of the PR?

@ishans-crest
Copy link
Contributor

Hi @JakePeralta7
Could you please update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants