Merge pull request #10 from splunk-soar-connectors/next

Merging next to main for release 2.1.0

.github/workflows/linting.yml

@@ -1,7 +1,7 @@
 name: Linting
 on: [push, pull_request]
 jobs:
-  lint: 
+  lint:
     # Run per push for internal contributers. This isn't possible for forked pull requests,
     # so we'll need to run on PR events for external contributers.
     # String comparison below is case insensitive.

.github/workflows/semgrep.yml

@@ -1,5 +1,5 @@
 name: Semgrep
-on: 
+on:
   pull_request_target:
     branches:
       - next
@@ -21,8 +21,8 @@ jobs:
         echo "REPOSITORY=${{ github.event.pull_request.head.repo.full_name }}" >> $GITHUB_ENV
         echo "REF=${{ github.event.pull_request.head.ref }}" >> $GITHUB_ENV
      - uses: 'phantomcyber/dev-cicd-tools/github-actions/semgrep@main'
-       with: 
+       with:
         SEMGREP_DEPLOYMENT_ID: ${{ secrets.SEMGREP_DEPLOYMENT_ID }}
         SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }}
-        REPOSITORY: ${{ github.repository }} 
+        REPOSITORY: ${{ github.repository }}
         REF: ${{ github.ref }}

.github/workflows/start-release.yml

@@ -1,9 +1,13 @@
 name: Start Release
-on: workflow_dispatch
+on:
+  workflow_dispatch:
+  push:
+    tags:
+      - '*-beta*'
 jobs:
   start-release:
     runs-on: ubuntu-latest
     steps:
      - uses: 'phantomcyber/dev-cicd-tools/github-actions/start-release@main'
        with:
-         GITHUB_TOKEN: ${{ secrets.SOAR_APPS_TOKEN }}
+         GITHUB_TOKEN: ${{ secrets.SOAR_APPS_TOKEN }}

.pre-commit-config.yaml

@@ -1,11 +1,11 @@
 repos:
 -   repo: https://github.com/phantomcyber/dev-cicd-tools
-    rev: v1.4
+    rev: v1.13
     hooks:
     -   id: org-hook
     -   id: package-app-dependencies
 -   repo: https://github.com/Yelp/detect-secrets
-    rev: v1.1.0
+    rev: v1.2.0
     hooks:
     -   id: detect-secrets
         args: ['--no-verify', '--exclude-files', '^adldap.json$']

LICENSE

@@ -186,7 +186,7 @@
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright 2021-2022 Splunk Inc.
+   Copyright (c) 2021-2022 Splunk Inc.
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.
@@ -198,4 +198,4 @@
    distributed under the License is distributed on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
-   limitations under the License.
+   limitations under the License.

README.md

@@ -2,18 +2,26 @@
 # AD LDAP
 
 Publisher: Splunk  
-Connector Version: 2\.0\.7
+Connector Version: 2\.1\.0  
 Product Vendor: Splunk  
 Product Name: Active Directory LDAP  
 Product Version Supported (regex): "\.\*"  
-Minimum Product Version: 4\.9\.39220  
+Minimum Product Version: 5\.2\.0  
 
 App specifically designed for interacting with Microsoft Active Directory's LDAP Implementation
 
-[comment]: # " File: readme.md"
-[comment]: # "  Copyright (c) 2021 Splunk Inc."
+[comment]: # " File: README.md"
+[comment]: # "     Copyright (c) 2021-2022 Splunk Inc."
+[comment]: # "     Licensed under the Apache License, Version 2.0 (the 'License');"
+[comment]: # "     you may not use this file except in compliance with the License."
+[comment]: # "     You may obtain a copy of the License at"
 [comment]: # ""
-[comment]: # "  Licensed under Apache 2.0 (https://www.apache.org/licenses/LICENSE-2.0.txt)"
+[comment]: # "       http://www.apache.org/licenses/LICENSE-2.0"
+[comment]: # ""
+[comment]: # "     Unless required by applicable law or agreed to in writing, software distributed under"
+[comment]: # "     the License is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,"
+[comment]: # "     either express or implied. See the License for the specific language governing permissions"
+[comment]: # "     and limitations under the License."
 [comment]: # ""
 ## App Information
 
@@ -41,6 +49,21 @@ delegate the appropriate least-privilege access to a service account with a very
 Lastly, it is strongly recommended to use SSL and disallow insecure (plain text and unsigned binds)
 if at all possible.
 
+## To add a custom certificate to the certificate store, follow the below steps:
+
+-   Need to install the certificate on the server
+
+      
+
+    -   Upload the SSL certificate on the server
+    -   Go to /opt/phantom/bin and execute the import_cert.py script using command:  
+        **phenv python3 import_cert.py -i "path_of_certificate_on_server"**
+
+-   Go to etc/hosts using the root user. Assign the domain to IP to use the SSL certificate
+
+**Note:** For reference: [Splunk
+Docs](https://docs.splunk.com/Documentation/SOARonprem/latest/Admin/AddOrRemoveCertificates)
+
 ## Run Query Action
 
 This action provides the user the ability to run generic queries with the LDAP syntax. The action
@@ -87,8 +110,8 @@ VARIABLE | REQUIRED | TYPE | DESCRIPTION
 **server** |  required  | string | The Active Directory Server hostname, IP, or VIP for binding
 **username** |  required  | string | The username with which to bind to LDAP
 **password** |  required  | password | The password for the binding user
-**force\_ssl** |  required  | boolean | Force the use of SSL protocol\. Note that some actions are not possible without secure binding\!
-**validate\_ssl\_cert** |  required  | boolean | Select if you want to validate the LDAP SSL certificate
+**force\_ssl** |  optional  | boolean | Force the use of SSL protocol\. Note that some actions are not possible without secure binding\!
+**validate\_ssl\_cert** |  optional  | boolean | Select if you want to validate the LDAP SSL certificate
 **ssl\_port** |  required  | numeric | The port to bind for SSL \(default 636\)
 
 ### Supported Actions  
@@ -423,4 +446,4 @@ action\_result\.parameter\.action | string |
 action\_result\.parameter\.attribute | string | 
 action\_result\.parameter\.use\_samaccountname | numeric | 
 summary\.total\_objects | numeric | 
-summary\.total\_objects\_successful | numeric | 
+summary\.total\_objects\_successful | numeric |