-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mtonderski/papp 33712 #37
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mctonderski-splunk
force-pushed
the
mtonderski/PAPP-33712
branch
from
June 17, 2024 14:37
5222328
to
3b9c584
Compare
ivellios
reviewed
Jun 17, 2024
mctonderski-splunk
force-pushed
the
mtonderski/PAPP-33712
branch
from
June 19, 2024 08:49
49a181e
to
c301120
Compare
ivellios
previously approved these changes
Jun 19, 2024
mposluszny-splunk
requested changes
Jun 19, 2024
mctonderski-splunk
force-pushed
the
mtonderski/PAPP-33712
branch
from
June 20, 2024 07:38
98b4051
to
d5b8fd5
Compare
mctonderski-splunk
force-pushed
the
mtonderski/PAPP-33712
branch
from
June 21, 2024 10:04
0196739
to
bc0d933
Compare
mposluszny-splunk
previously approved these changes
Jun 21, 2024
mctonderski-splunk
dismissed stale reviews from mposluszny-splunk and ivellios
via
July 12, 2024 10:04
23db524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
please document them in the
manual_readme_content.md
.manual_readme_content.md
all methods (eg, OAuth) used to authenticatewith the service that the connector is integrating with.
manual_readme_content.md
.the Vault API.
nosemgrep
?If yes, please provide justification in an additional comment next to the ignored code.
Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!