-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git - Add File - 'utf8' codec can't decode byte in position 0: invalid start byte #13
base: next
Are you sure you want to change the base?
Conversation
Thank you for your submission! We have a total of 18 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can. |
@HarlodHolt Static Tests results for commit a5cd9a4 - https://drive.google.com/file/d/1_Zx6gmFPKTGn8d52A8uGHNHOa0tdXkbr/view?usp=drivesdk |
@HarlodHolt Compile Tests results for commit a5cd9a4 - https://drive.google.com/file/d/1VJhMqd0zX3I3Sd04rRKfI6k7z8ZQJt-3/view?usp=drivesdk |
@mishalp-crest Static Tests results for commit 9e39ccb - https://drive.google.com/file/d/1f2VzZkUkBfDR67ZqZG7OYiM9vKYNkgl1/view?usp=drivesdk |
@mishalp-crest Compile Tests results for commit 9e39ccb - https://drive.google.com/file/d/1IT1EvQwrNF_aUxxEDW4Of92l0ilLUqg2/view?usp=drivesdk |
@mishalp-crest Static Tests results for commit e99fd15 - https://drive.google.com/file/d/1cYlXCntsuwyNMS85Dvsc-IQdl_roICjM/view?usp=drivesdk |
@mishalp-crest Compile Tests results for commit e99fd15 - https://drive.google.com/file/d/1uu2NYGBv-5A5qNF5k18nLI7CLxo9l5Ja/view?usp=drivesdk |
@mishalp-crest Static Tests results for commit b9e3718 - https://drive.google.com/file/d/1rWpjGZ0afHQYA0P289A7ilAImyJpf2yy/view?usp=drivesdk |
@mishalp-crest Compile Tests results for commit b9e3718 - https://drive.google.com/file/d/1gUXBX1HYme6G46uHAUKXgKJdYEGfXzH5/view?usp=drivesdk |
@mishalp-crest Static Tests results for commit a760aaa - https://drive.google.com/file/d/1G8v8QRaIxBrjcee_XMFDDjoQBPXhwfJP/view?usp=drivesdk |
@mishalp-crest Compile Tests results for commit a760aaa - https://drive.google.com/file/d/12Cn7mgof35mQWaapzWVJYWFKs8x-Q4OC/view?usp=drivesdk |
@mishalp-crest Static Tests results for commit 171174c - https://drive.google.com/file/d/1xNrgzSshBm-N-Ma-Q6otgZzlKEyEbEZi/view?usp=drivesdk |
@mishalp-crest Compile Tests results for commit 171174c - https://drive.google.com/file/d/1bLI2JjNVRlyMwOuKEHGNn-r0KNadmube/view?usp=drivesdk |
@mishalp-crest Static Tests results for commit 57b4088 - https://drive.google.com/file/d/19t5O-4r_tyg_dmdtvHT5wiFAlRUPSybB/view?usp=drivesdk |
@mishalp-crest Compile Tests results for commit 57b4088 - https://drive.google.com/file/d/11Koi4iLYV1ODPA7e5K7dhJ8wEMAxlGXX/view?usp=drivesdk |
@mishalp-crest Static Tests results for commit 11855b6 - https://drive.google.com/file/d/1NOaBjaNFDF1L_kEIE_YkyEyl_ueLgaBQ/view?usp=drivesdk |
@mishalp-crest Compile Tests results for commit 11855b6 - https://drive.google.com/file/d/1505lA55Hp8EQdVM3tr8EEkBMhDMs2jRO/view?usp=drivesdk |
@mishalp-crest Static Tests results for commit bb4eec8 - https://drive.google.com/file/d/106gumPhYRPP29x8dQkS62lKFYHwN8vwE/view?usp=drivesdk |
@mishalp-crest Compile Tests results for commit bb4eec8 - https://drive.google.com/file/d/1Fcpe9sKO99bYoYoLWzCSmTUbBn23A8yH/view?usp=drivesdk |
Name of the app
git
Describe the bug
When attempting to use add file to add a file to the repository files that cannot be read into 'utf8' are failing with the expectation "'utf8' codec can't decode byte 0xa5 in position 0: invalid start byte" as an example.
To Reproduce
Steps to reproduce the behavior:
Create Event/Container with a .xlsm file type as a vault artifact
Use Clone repo to bring done repo
Use Add File to move file to repo from vault location
See error
Expected behavior
It appears files that cannot be read are failing with 'utf8' are failing with the expectation "'utf8' codec can't decode byte 0xa5 in position 0: invalid start byte" as an example.
Splunk SOAR Version (please complete the following information):
Unprivileged Install - SOAR 5.5
OS Version - RHEL 8.7
App Version - GIT 2.1.0
Additional context
Modify git_connector.py
changing read_text() to read_bytes() seems to work
255 vault_file_data = vault_file_path.read_text() > vault_file_data = vault_file_path.read_bytes()
271 full_path.write_text(file_data) > full_path.write_bytes(file_data)
I am no expert and not sure what implications this has but this is a viable solution for our instance.