Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAPP-34667: Fix code quality issues #3

Merged
merged 18 commits into from
Oct 10, 2024
Merged

Conversation

tapishj-splunk
Copy link
Contributor

@tapishj-splunk tapishj-splunk commented Sep 6, 2024

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Screenshots (if relevant)


Thanks for contributing!

LICENSE Outdated Show resolved Hide resolved
__init__.py Outdated Show resolved Hide resolved
talosintelligence.json Show resolved Hide resolved
talosintelligence.json Outdated Show resolved Hide resolved
talosintelligence.json Outdated Show resolved Hide resolved
talosintelligence.json Outdated Show resolved Hide resolved
talosintelligence.json Outdated Show resolved Hide resolved
talosintelligence.json Outdated Show resolved Hide resolved
talosintelligence.json Outdated Show resolved Hide resolved
@tapishj-splunk tapishj-splunk merged commit 310af24 into next Oct 10, 2024
@tapishj-splunk tapishj-splunk deleted the tapishj/PAPP-34667 branch October 10, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants