Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle defaults of updateOnSdk props, when non boolean values are provided #219

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Handle defaults of updateOnSdk props, when non boolean values are provided #219

wants to merge 6 commits into from

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Nov 5, 2024 •
edited
Loading

React SDK

What did you accomplish?

  • Fixed an issue with the updateOn*** object parameters of the useSplitClient and useSplitTreatments hooks, and their components and HOCs alternatives, which were not defaulting to true when a non-boolean value was provided.

How do we test the changes introduced in this PR?

  • Updated unit tests.

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 5, 2024 17:05
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

95.2% 95.2% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EmilianoSanchez