-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds indicatorGradient to ToggleStyle #45
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 96.91% 96.93% +0.02%
==========================================
Files 7 7
Lines 777 783 +6
==========================================
+ Hits 753 759 +6
Misses 24 24
☔ View full report in Codecov by Sentry. |
What does it take to be accepted? |
@denisgl7 I need to do some more testing and don't know when I'll have the time. But feel free to include this version in your project already if you need the feature now.
|
Everything works great! In fact, you just need to check whether the color or the gradient will be used in priority. As far as I understand - you just put a gradient on the container. Thank you very much for adding this feature! |
2023-10-07.10.32.21.movCan you tell me why changing the theme takes so long in your component? I tried changing the animation time and it was no use. Should I create a separate issue? |
@denisgl7 You can create an issue, but I won't be able to fix this problem so easily. All changes in the |
I don't feel comfortable asking you to change anything else. I'll try to fix the problem myself :) |
@denisgl7 I don't think you can fix this problem from outside. Create an issue and I'll take a look at it. 👍 |
closes #44
closes #46