Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pack_varbin #674

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Fix pack_varbin #674

merged 3 commits into from
Aug 21, 2024

Conversation

robert3005
Copy link
Member

Sliced VarBin arrays don't rewrite offsets and bytes so we need to perform the
adjustment when concatenating them

@robert3005 robert3005 enabled auto-merge (squash) August 21, 2024 16:08
@robert3005 robert3005 disabled auto-merge August 21, 2024 16:08
@robert3005 robert3005 enabled auto-merge (squash) August 21, 2024 16:10
Copy link
Contributor

@AdamGS AdamGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert3005 robert3005 merged commit 8679d85 into develop Aug 21, 2024
4 checks passed
@robert3005 robert3005 deleted the rk/fixpackvarbin branch August 21, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants