Add FSST encoding #645
Merged
Add FSST encoding #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
reviewed
Aug 19, 2024
AdamGS
reviewed
Aug 19, 2024
AdamGS
approved these changes
Aug 19, 2024
robert3005
reviewed
Aug 19, 2024
encodings/fsst/src/compute.rs
Outdated
Comment on lines
68
to
80
| if matches!(self.dtype(), &DType::Utf8(_)) { | ||
| // SAFETY: a UTF-8 FSSTArray can only be compressed from a known-good UTF-8 array, no need to revalidate. | ||
| let buffer_string = unsafe { BufferString::new_unchecked(decoded_buffer) }; | ||
| Ok(Scalar::new( | ||
| self.dtype().clone(), | ||
| ScalarValue::BufferString(buffer_string), | ||
| )) | ||
| } else { | ||
| Ok(Scalar::new( | ||
| self.dtype().clone(), | ||
| ScalarValue::Buffer(decoded_buffer), | ||
| )) | ||
| } |
There was a problem hiding this comment.
there's a varbin_scalar function in VarBinArray which I think does the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the FSSTArray, leaning on the shiny new
fsst-rscrate we're publishing.This does not implement the encoding compressor, will do that in a follow-on.