Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FoR compressor handles nullable arrays #617

Merged
merged 4 commits into from
Aug 13, 2024
Merged

FoR compressor handles nullable arrays #617

merged 4 commits into from
Aug 13, 2024

Conversation

robert3005
Copy link
Member

No description provided.

@robert3005 robert3005 enabled auto-merge (squash) August 13, 2024 16:02
@robert3005 robert3005 disabled auto-merge August 13, 2024 16:05
@robert3005 robert3005 enabled auto-merge (squash) August 13, 2024 16:16
AdamGS
AdamGS approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@AdamGS AdamGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this code is very dense, but that's probably inevitable given the context required to maintain it. Maybe in the long term we'll need to add references and/or just more rustdoc and comments.

@robert3005 robert3005 merged commit 18a788e into develop Aug 13, 2024
3 checks passed
@robert3005 robert3005 deleted the rk/fornulls branch August 13, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamGS AdamGS AdamGS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert3005 @AdamGS