Hook on-disk vortex files into benchmarking #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/benchmark-on-disk-vortex
branch
from
cf43e18 to
f4faa93
Compare
AdamGS
force-pushed
the
adamg/benchmark-on-disk-vortex
branch
from
dac788d to
6709da8
Compare
AdamGS
changed the title
robert3005
approved these changes
Aug 8, 2024
robert3005
reviewed
Aug 8, 2024
| EquivalenceProperties::new(file_scan_config.file_schema.clone()), | ||
| partitioning, | ||
| EquivalenceProperties::new(projected_schema), | ||
| Partitioning::UnknownPartitioning(1), |
There was a problem hiding this comment.
we should figure this one out. Requires some extra config in the reader
There was a problem hiding this comment.
Right now, we do only use a single partition in the file scan as all files are in the same group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Vortex on-file format to our benchmarking suite