Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor specialized conversion traits into From and Into #560

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Refactor specialized conversion traits into From and Into #560

merged 6 commits into from
Aug 7, 2024

Conversation

AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Aug 6, 2024 •
edited
Loading

We have a few traits that define conversion behavior between types that can be expressed by the usual From/Into traits, making the overall API somewhat more idiomatic.
As of now, this PR removes ToArrayData and IntoArrayData.

robert3005
robert3005 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you're here we should refactor the Arrow conversion trait to return an Array instead of ArrayData to simplify thins slightly, i.e. there shouldn't be a reason to strongly prefer ArrayData for any operation

@AdamGS AdamGS enabled auto-merge (squash) August 7, 2024 10:10
@AdamGS AdamGS merged commit 7f57019 into develop Aug 7, 2024
3 checks passed
@AdamGS AdamGS deleted the adamg/remove-conversion-traits branch August 7, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert3005 robert3005 robert3005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamGS @robert3005