File-based table provider for Datafusion #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
commented
Aug 5, 2024
AdamGS
changed the title
robert3005
reviewed
Aug 5, 2024
robert3005
reviewed
Aug 5, 2024
| builder = builder.with_projection(Projection::new(projection)) | ||
| } | ||
|
|
||
| DFResult::Ok( |
There was a problem hiding this comment.
We should figure out fmt/clippy rule for this
There was a problem hiding this comment.
There's a rule, however, it's very fiddly to configure. Will have a look at some point if there's a simple setup
robert3005
approved these changes
Aug 5, 2024
|
I wonder how datafusion handles massive file listing. I have a feeling it might just oom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a very minimal
TableProviderto read vortex-encoded files.