Rename the pushdown config into a positive boolean value #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/pushdown-positive-bools
branch
from
cf44589 to
4537a52
Compare
a10y
reviewed
Aug 2, 2024
| @@ -50,12 +50,12 @@ const SUPPORTED_BINARY_OPS: &[Operator] = &[ | |||
| /// Optional configurations to pass when loading a [VortexMemTable]. | |||
| #[derive(Default, Debug, Clone)] | |||
| pub struct VortexMemTableOptions { | |||
| pub disable_pushdown: bool, | |||
| pub enable_pushdown: bool, | |||
There was a problem hiding this comment.
If we do this we need to impl default by hand
There was a problem hiding this comment.
nice catch, I'll add that to the file provider PR
Merged
AdamGS
added a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.