Initial version of simple FileReader/Writer #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
commented
Jul 24, 2024
robert3005
commented
Jul 24, 2024
robert3005
commented
Jul 24, 2024
Comment on lines
+166
to
+208
| let len = chunk.byte_offsets.len() - 1; | ||
| let byte_counts = chunk | ||
| .byte_offsets | ||
| .iter() | ||
| .skip(1) | ||
| .zip(chunk.byte_offsets.iter()) | ||
| .map(|(a, b)| a - b) | ||
| .collect_vec(); | ||
|
|
||
| chunks.extend( | ||
| chunk | ||
| .byte_offsets | ||
| .iter() | ||
| .zip(chunk.byte_offsets.iter().skip(1)) | ||
| .map(|(begin, end)| Layout::Flat(FlatLayout::new(*begin, *end))), | ||
| ); | ||
| let row_counts = chunk | ||
| .row_offsets | ||
| .iter() | ||
| .skip(1) | ||
| .zip(chunk.row_offsets.iter()) | ||
| .map(|(a, b)| a - b) | ||
| .collect_vec(); | ||
| chunk.byte_offsets.truncate(len); | ||
| chunk.row_offsets.truncate(len); | ||
|
|
||
| let metadata_array = StructArray::try_new( | ||
| [ | ||
| "byte_offset".into(), | ||
| "byte_count".into(), | ||
| "row_offset".into(), | ||
| "row_count".into(), | ||
| ] | ||
| .into(), | ||
| vec![ | ||
| chunk.byte_offsets.into_array(), | ||
| byte_counts.into_array(), | ||
| chunk.row_offsets.into_array(), | ||
| row_counts.into_array(), | ||
| ], | ||
| len, | ||
| Validity::NonNullable, | ||
| )?; |
There was a problem hiding this comment.
This logic beyond extending chunks byte offsets is highly suspect. We can't reuse these tables in ChunkedArrayReader which is a bad thing. I wonder if we need to store multiple metadata tables since the offset tables are going to be 1 row longer than stat tables. OR the byte/row offsets live in layouts and these tables are pure metadata.
a10y
reviewed
Jul 25, 2024
|
note that the new vortex_serde tests appear to take a LOOONG time in miri, probably worth adding |
AdamGS
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reader currently assumes Chunked(Column(Chunked)) layouts. This is going to be expanded in follow ups