Smoketest for SamplingCompressor, fix bug in varbin stats #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of failures in the past few months that only show up in an ETE test like random_access benchmark. However, random_access benchmark is very slow to run in CI. I'm adding a very tiny SamplingCompressor test that runs at CI time. It takes <1s on my macbook, and uses 65k rows of synthetic data to try and get the compressor to go down a few common paths. It's not perfect, but it does trigger Constant, DateTimeParts, Dict and Bitpacking
|
CI Overhead seems to be minimal: 
|
robert3005
reviewed
Jul 24, 2024
| Ordering::Less => self.is_sorted = false, | ||
| Ordering::Less => { | ||
| self.is_sorted = false; | ||
| self.is_strict_sorted = false; |
robert3005
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of failures in the past few months that only show up in an ETE test like random_access benchmark. However, random_access benchmark is very slow to run in CI.
I'm adding a very tiny SamplingCompressor test that runs at CI time. It takes <1s on my macbook, and uses 65k rows of synthetic data to try and get the compressor to go down a few common paths.
It's not perfect, but it does trigger Constant, DateTimeParts, Dict and could trigger Bitpacking if we implement #509.
Bonus: after writing this test and examining the compressed output in a few scenarios, I was noticing that Dict compression was never kicking in for out-of-order arrays. It looks like we were computing the is_strict_sorted stat incorrectly for varbin.