New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension DType canonicalization behaves as other array types #500

Closed

robert3005 wants to merge 1 commit into develop from rk/canonical

Member

robert3005 commented Jul 22, 2024

No description provided.


          Extension DType canonicalization behaves as other array types

1f6df34

robert3005 commented

View reviewed changes

vortex-array/src/array/chunked/canonical.rs

@@ @@ -47,9 +47,17 @@ pub(crate) fn try_canonicalize_chunks( @@
                       // Extension arrays wrap an internal storage array, which can hold a ChunkedArray until
                       // it is safe to unpack them.
                       DType::Extension(ext_dtype, _) => {
+                          if chunks.is_empty() {

Member Author

robert3005 Jul 22, 2024

there's a fun case of "What is the canonical storage type for an extension dtype"?

robert3005 closed this

robert3005 deleted the rk/canonical branch

July 22, 2024 20:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet