Fix SparseArray validity logic and give DateTimeParts unique code

encodings/datetime-parts/src/array.rs

@@ -11,7 +11,7 @@ use vortex_error::{vortex_bail, VortexResult};
 
 use crate::compute::decode_to_temporal;
 
-impl_encoding!("vortex.datetimeparts", 20u16, DateTimeParts);
+impl_encoding!("vortex.datetimeparts", 22u16, DateTimeParts);
 
 #[derive(Clone, Debug, Serialize, Deserialize)]
 pub struct DateTimePartsMetadata {

vortex-array/src/array/sparse/flatten.rs

@@ -49,8 +49,8 @@ fn canonicalize_sparse_bools(
         fill_value.try_into()?
     };
     let mut flat_bools = vec![fill_bool; len];
-    for idx in indices {
-        flat_bools[*idx] = values.value(*idx);
+    for (i, idx) in indices.iter().enumerate() {
+        flat_bools[*idx] = values.value(i);
         validity.set_bit(*idx, true);
     }
 

vortex-array/src/array/sparse/mod.rs

@@ -54,6 +54,13 @@ impl SparseArray {
                 values.dtype(),
             );
         }
+        if indices.len() != values.len() {
+            vortex_bail!(
+                "Mismatched indices {} and values {} length",
+                indices.len(),
+                values.len()
+            );
+        }
 
         Self::try_from_parts(
             values.dtype().clone(),
@@ -80,7 +87,7 @@ impl SparseArray {
     #[inline]
     pub fn values(&self) -> Array {
         self.array()
-            .child(1, self.dtype(), self.indices().len())
+            .child(1, self.dtype(), self.metadata().indices_len)
             .expect("missing child array")
     }
 
@@ -157,10 +164,10 @@ impl ArrayValidity for SparseArray {
             // of true, and patch values of false.
             Self::try_new_with_offset(
                 self.indices(),
-                ConstantArray::new(false, self.len()).into_array(),
+                ConstantArray::new(true, self.indices().len()).into_array(),
                 self.len(),
                 self.indices_offset(),
-                true.into(),
+                false.into(),
             )
         } else {
             // If the fill_value is non-null, then the validity is based on the validity of the
@@ -171,7 +178,7 @@ impl ArrayValidity for SparseArray {
                     .with_dyn(|a| a.logical_validity().into_array()),
                 self.len(),
                 self.indices_offset(),
-                true.into(),
+                false.into(),
             )
         }
         .unwrap();
@@ -338,4 +345,18 @@ mod test {
         assert_eq!(start, 0);
         assert_eq!(stop, 5);
     }
+
+    #[test]
+    pub fn sparse_logical_validity() {
+        let array = sparse_array(nullable_fill());
+        let validity = array
+            .with_dyn(|a| a.logical_validity())
+            .into_array()
+            .into_bool()
+            .unwrap();
+        assert_eq!(
+            validity.boolean_buffer().iter().collect_vec(),
+            [false, false, true, false, false, true, false, false, true, false]
+        );
+    }
 }