Expand pushdown support with more comparison and logical operations #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/expand-pushdown-support
branch
from
098fd7c to
b6a80bc
Compare
gatesn
requested changes
Jul 18, 2024
| let rhs = ExpressionEvaluator::eval(array.clone(), rhs)?; | ||
| compare(&lhs, &rhs, Operator::Eq) | ||
| } | ||
| DFOperator::Eq => compare(&lhs, &rhs, Operator::Eq), |
There was a problem hiding this comment.
Can we define a TryFrom<DFOperator> for Operator? And then use that to check for support?
There was a problem hiding this comment.
And and Or don't really fit into how Operator is designed right now with functions like to_predicate or even inverse
gatesn
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for more comparisons and add recursive validation logic for expressions.