Rest of TPCH #459
Merged
Rest of TPCH #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added some coloration: cells will have yellow background if they're 10-50% slower than arrow, red background if they are >50% slower, green otherwise |
a10y
force-pushed
the
ngates/tpch-benchmarks
branch
from
1f5c517 to
9c1f7b1
Compare
a10y
approved these changes
Jul 16, 2024
|
For comparison, here's what it looks like if you run all of them single-threaded
It seems for Q2, Q11, Q19, doing single-threaded VS multi-threaded makes a large difference |
gatesn
pushed a commit
that referenced
this pull request
Jul 16, 2024
In #459 , we used an 8-thread pool and a single tokio runtime to run all of the queries in parallel. There was huge variability on the values returned by those benchmarks. This PR * Switches from using tokio global runtime for parallelism to using a Rayon pool * Each query executes in a current-thread tokio runtime, which should be a bit more apples-to-apples * Removed CSV measurements, and now have each query+format pair do 3 warmup runs, followed by 20 measured runs, then take the min over measurements * Fixed the coloration logic for table (oops) * A few small drive-bys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.