Add FilterFn trait + default implementation #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
commented
Jul 15, 2024
| /// | ||
| /// We expect to change this soon once DataFusion is able to finish up some initial support, which | ||
| /// is tracked in https://github.com/apache/datafusion/issues/10918. | ||
| /// is tracked in <https://github.com/apache/datafusion/issues/10918>. |
There was a problem hiding this comment.
these were cleanups to make cargo doc -p vortex-array complete cleanly
robert3005
approved these changes
Jul 15, 2024
Closed
|
|
||
| array.with_dyn(|a| { | ||
| if let Some(filter_fn) = a.filter() { | ||
| Ok(filter_fn.filter(array)) |
There was a problem hiding this comment.
Should this be filter_fn.filter(predicate)
There was a problem hiding this comment.
Ill fix it in a follow up.
|
|
||
| pub trait FilterFn { | ||
| /// Filter an array by the provided predicate. | ||
| fn filter(&self, predicate: &Array) -> Array; |
There was a problem hiding this comment.
What do you think about moving to this taking a &dyn BoolArrayTrait?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
filterand correspondingFilterFnarray traitSee #439