Chunked take #447
Merged
Chunked take #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gatesn
commented
Jul 10, 2024
gatesn
commented
- Improves the performance of ChunkedArray::take for strict-sorted indices.
- Makes subtraction wrapping instead of doing an expensive statistics test
- Fixes PrimitiveArray slice to be zero-copy
a10y
reviewed
Jul 10, 2024
| let contains_nulls = !subtract_from.logical_validity().all_valid(); | ||
| let subtraction_result = if contains_nulls { | ||
| let sub_vec = subtract_from | ||
| .maybe_null_slice() | ||
| .iter() | ||
| .map(|&v: &T| v.saturating_sub(&to_subtract)) | ||
| .map(|&v: &T| v.wrapping_sub(&to_subtract)) |
There was a problem hiding this comment.
why are we changing the behavior of this, and removing the assertions?
There was a problem hiding this comment.
The assertions are expensive since they require computing stats.
We could either just use checked subtraction and allow this to panic, or we pick between saturating and wrapping.
Tbh, I've never seen unchecked subtraction do anything other than wrap, so it seemed like the better choice. e.g. https://arrow.apache.org/docs/python/generated/pyarrow.compute.subtract.html
robert3005
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.