Array Length #445
Merged
Array Length #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
reviewed
Jul 10, 2024
| } | ||
|
|
||
| #[inline] | ||
| pub fn chunk(&self, idx: usize) -> Option<Array> { | ||
| let chunk_start = usize::try_from(&scalar_at(&self.chunk_ends(), idx).unwrap()).unwrap(); |
There was a problem hiding this comment.
There's a method on primitive array to get the scalar value out. Since we construct the ends array ourselves it should be safe to use it
There was a problem hiding this comment.
Not if it's been compressed
There was a problem hiding this comment.
hmm, ok, forgot this can be read
a10y
approved these changes
Jul 10, 2024
| @@ -65,11 +76,12 @@ impl ArrayData { | |||
| self.buffer | |||
| } | |||
|
|
|||
| pub fn child(&self, index: usize, dtype: &DType) -> Option<&Array> { | |||
| pub fn child(&self, index: usize, dtype: &DType, len: usize) -> Option<&Array> { | |||
There was a problem hiding this comment.
both this and the dtype check feel potentially unnecessary, or at least maybe could be debug assertions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.