Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Slice and SearchSorted for BitPackedArray #410

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Fix Slice and SearchSorted for BitPackedArray #410

merged 3 commits into from
Jun 25, 2024

Conversation

robert3005
Copy link
Member

No description provided.

@robert3005 robert3005 enabled auto-merge (squash) June 25, 2024 12:41
@robert3005 robert3005 changed the title Fix Slice and SearchSorted on BitPackedArray Fix Slice and SearchSorted for BitPackedArray Jun 25, 2024
a10y
a10y approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to capture 1024 as a constant for use in logic/tests at some point

@robert3005 robert3005 merged commit af10b71 into develop Jun 25, 2024
2 checks passed
@robert3005 robert3005 deleted the rk/packedslicesearch branch June 25, 2024 13:00
@robert3005
Copy link
Member Author

Yes, 1024 is magical all over the place. Let me do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a10y a10y a10y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert3005 @a10y