Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StructValue proto serde without google.protobuf.Value #343

Merged
merged 2 commits into from
Jun 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion vortex-scalar/proto/vortex/scalar/scalar.proto
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,29 @@ package vortex.scalar;

import "vortex/dtype/dtype.proto";
import "google/protobuf/struct.proto";
import "google/protobuf/wrappers.proto";

message Scalar {
vortex.dtype.DType dtype = 1;
ScalarValue value = 2;
}

message ScalarValue {
google.protobuf.Value value = 1;
oneof kind {
google.protobuf.NullValue null_value = 1;
bool bool_value = 2;
int32 int32_value = 3;
int64 int64_value = 4;
uint32 uint32_value = 5;
uint64 uint64_value = 6;
float float_value = 7;
double double_value = 8;
string string_value = 9;
bytes bytes_value = 10;
ListValue list_value = 12;
}
}

message ListValue {
repeated ScalarValue values = 1;
}
Loading