Expose ViewContext and page byte ranges in array reader #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
commented
May 23, 2024
robert3005
changed the title
gatesn
approved these changes
Jun 4, 2024
| @@ -107,5 +107,5 @@ zigzag = "0.1.0" | |||
| warnings = "deny" | |||
|
|
|||
| [workspace.lints.clippy] | |||
| all = "deny" | |||
| all = { level = "deny", priority = -1 } | |||
There was a problem hiding this comment.
This is part of us using nightly, seems like they now complain if two rules have same "priority" so you make this priority lower so it can be overriden by individual rules
| @@ -300,7 +300,7 @@ pub fn unpack_single(array: &BitPackedArray, index: usize) -> VortexResult<Scala | |||
| /// The caller must ensure the following invariants hold: | |||
| /// * `packed.len() == (length + 1023) / 1024 * 128 * bit_width` | |||
| /// * `index_to_decode < length` | |||
| /// Where `length` is the length of the array/slice backed by `packed` (but is not provided to this function). | |||
| /// Where `length` is the length of the array/slice backed by `packed` (but is not provided to this function). | |||
There was a problem hiding this comment.
This is also us using nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.