Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal expressions API for vortex #308

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ members = [
"vortex-datetime-parts",
"vortex-dict",
"vortex-error",
"vortex-expr",
"vortex-fastlanes",
"vortex-flatbuffers",
"vortex-ipc",
Expand Down
3 changes: 2 additions & 1 deletion vortex-dtype/src/dtype.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ use DType::*;
use crate::nullability::Nullability;
use crate::{ExtDType, PType};

pub type FieldNames = Arc<[Arc<str>]>;
pub type FieldName = Arc<str>;
pub type FieldNames = Arc<[FieldName]>;

pub type Metadata = Vec<u8>;

Expand Down
20 changes: 20 additions & 0 deletions vortex-dtype/src/ptype.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,26 @@ macro_rules! match_each_native_ptype {
})
}

#[macro_export]
macro_rules! match_each_signed_ptype {
($self:expr, | $_:tt $enc:ident | $($body:tt)*) => ({
macro_rules! __with__ {( $_ $enc:ident ) => ( $($body)* )}
use $crate::PType;
use $crate::half::f16;
match $self {
PType::I8 => __with__! { i8 },
PType::I16 => __with__! { i16 },
PType::I32 => __with__! { i32 },
PType::I64 => __with__! { i64 },
PType::F16 => __with__! { f16 },
jdcasale marked this conversation as resolved.
Show resolved Hide resolved
PType::F32 => __with__! { f32 },
PType::F64 => __with__! { f64 },
_ => panic!("Unsupported ptype {}", $self),

}
})
}

#[macro_export]
macro_rules! match_each_integer_ptype {
($self:expr, | $_:tt $enc:ident | $($body:tt)*) => ({
Expand Down
23 changes: 23 additions & 0 deletions vortex-expr/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
[package]
name = "vortex-expr"
version = { workspace = true }
description = "Vortex Expressions"
homepage = { workspace = true }
repository = { workspace = true }
authors = { workspace = true }
license = { workspace = true }
keywords = { workspace = true }
include = { workspace = true }
edition = { workspace = true }
rust-version = { workspace = true }

[lints]
workspace = true

[dependencies]
vortex-dtype = { path = "../vortex-dtype" }
vortex-error = { path = "../vortex-error" }
vortex-scalar = { path = "../vortex-scalar" }


[dev-dependencies]
8 changes: 8 additions & 0 deletions vortex-expr/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Vortex Expressions

Expressions for querying vortex arrays. The query algebra is designed to express a minimal
jdcasale marked this conversation as resolved.
Show resolved Hide resolved
superset of linear operations that can be pushed down to vortex metadata. Conversely, not all
operations that can be expressed in this algebra can be pushed down to metadata.

Takes inspiration from postgres https://www.postgresql.org/docs/current/sql-expressions.html
and datafusion https://github.com/apache/datafusion/tree/5fac581efbaffd0e6a9edf931182517524526afd/datafusion/expr
160 changes: 160 additions & 0 deletions vortex-expr/src/display.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
use core::fmt;
use std::fmt::{Display, Formatter};

use vortex_dtype::{match_each_native_ptype, DType};
use vortex_scalar::{BoolScalar, PrimitiveScalar};

use crate::expressions::{BinaryExpr, Expr};
use crate::operators::{Associativity, Operator};
use crate::scalar::ScalarDisplayWrapper;

impl Display for Expr {
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
match self {
Expr::Binary(expr) => write!(f, "{expr}"),
Expr::Field(d) => write!(f, "{d}"),
Expr::Literal(v) => {
let wrapped = ScalarDisplayWrapper(v);
write!(f, "{wrapped}")
}
Expr::Not(expr) => write!(f, "NOT {expr}"),
Expr::Minus(expr) => write!(f, "(- {expr})"),
jdcasale marked this conversation as resolved.
Show resolved Hide resolved
Expr::IsNull(expr) => write!(f, "{expr} IS NULL"),
}
}
}

enum Side {
Left,
Right,
}

impl Display for BinaryExpr {
fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
fn write_inner(
f: &mut Formatter<'_>,
outer: &Expr,
outer_op: Operator,
side: Side,
) -> fmt::Result {
if let Expr::Binary(inner) = outer {
let inner_op_precedence = inner.op.precedence();
// if the inner operator has higher precedence than the outer expression,
// wrap it in parentheses to prevent inversion of priority
if inner_op_precedence > outer_op.precedence() ||
// if the inner and outer operators have the same precedence, we need to
// account for operator associativity when determining grouping
(inner_op_precedence == outer_op.precedence() &&
match side {
Side::Left => {
outer_op.associativity() == Associativity::Left
}
Side::Right => {
outer_op.associativity() == Associativity::Right
}
})
{
write!(f, "({inner})")?;
} else {
write!(f, "{inner}")?;
}
} else if let Expr::Literal(scalar) = outer {
// use alternative formatting for scalars
let wrapped = ScalarDisplayWrapper(scalar);
write!(f, "{wrapped}")?;
} else {
write!(f, "{outer}")?;
}
Ok(())
}

write_inner(f, self.left.as_ref(), self.op, Side::Left)?;
write!(f, " {} ", self.op)?;
write_inner(f, self.right.as_ref(), self.op, Side::Right)
}
}

/// Alternative display for scalars
impl Display for ScalarDisplayWrapper<'_> {
fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
match self.0.dtype() {
DType::Null => write!(f, "null"),
DType::Bool(_) => match BoolScalar::try_from(self.0).expect("bool").value() {
None => write!(f, "null"),
Some(b) => write!(f, "{}", b),
},
DType::Primitive(ptype, _) => match_each_native_ptype!(ptype, |$T| {
match PrimitiveScalar::try_from(self.0).expect("primitive").typed_value::<$T>() {
None => write!(f, "null"),
Some(v) => write!(f, "{}{}", v, std::any::type_name::<$T>()),
}
}),
DType::Utf8(_) => todo!(),
DType::Binary(_) => todo!(),
DType::Struct(..) => todo!(),
DType::List(..) => todo!(),
DType::Extension(..) => todo!(),
}
}
}

impl Display for Operator {
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
let display = match &self {
Operator::And => "AND",
Operator::Or => "OR",
Operator::EqualTo => "=",
Operator::NotEqualTo => "!=",
Operator::GreaterThan => ">",
Operator::GreaterThanOrEqualTo => ">=",
Operator::LessThan => "<",
Operator::LessThanOrEqualTo => "<=",
Operator::Plus => "+",
Operator::Minus | Operator::UnaryMinus => "-",
Operator::Multiplication => "*",
Operator::Division => "/",
Operator::Modulo => "%",
};
write!(f, "{display}")
}
}

#[cfg(test)]
mod tests {
use crate::expression_fns::{equals, field};
use crate::literal::lit;

#[test]
fn test_formatting() {
// Addition
assert_eq!(format!("{}", lit(1u32) + lit(2u32)), "1u32 + 2u32");
// Subtraction
assert_eq!(format!("{}", lit(1u32) - lit(2u32)), "1u32 - 2u32");
// Multiplication
assert_eq!(format!("{}", lit(1u32) * lit(2u32)), "1u32 * 2u32");
// Division
assert_eq!(format!("{}", lit(1u32) / lit(2u32)), "1u32 / 2u32");
// Modulus
assert_eq!(format!("{}", lit(1u32) % lit(2u32)), "1u32 % 2u32");
// Negate
assert_eq!(format!("{}", -lit(1u32)), "(- 1u32)");

// And
let string = format!("{}", lit(true).and(lit(false)));
assert_eq!(string, "true AND false");
// Or
let string = format!("{}", lit(true).or(lit(false)));
assert_eq!(string, "true OR false");
// Not
let string = format!("{}", !lit(1u32));
assert_eq!(string, "NOT 1u32");
}

#[test]
fn test_format_respects_operator_associativity() {
let left = field("id").eq(lit(1));
let right = field("id2").eq(-lit(2));
let s = format!("{}", equals(left, right));
assert_eq!(s, "id = 1i32 = (id2 = (- 2i32))")
}
}
43 changes: 43 additions & 0 deletions vortex-expr/src/expression_fns.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
use vortex_dtype::FieldName;

use crate::expressions::BinaryExpr;
use crate::expressions::Expr;
use crate::operators::Operator;

#[allow(dead_code)]
jdcasale marked this conversation as resolved.
Show resolved Hide resolved
pub fn binary_expr(left: Expr, op: Operator, right: Expr) -> Expr {
Expr::Binary(BinaryExpr::new(Box::new(left), op, Box::new(right)))
}

/// Create a field expression based on a qualified field name.
#[allow(dead_code)]
pub fn field(field: impl Into<FieldName>) -> Expr {
Expr::Field(field.into())
}

#[allow(dead_code)]
pub fn equals(left: Expr, right: Expr) -> Expr {
Expr::Binary(BinaryExpr::new(
Box::new(left),
Operator::EqualTo,
Box::new(right),
))
}

#[allow(dead_code)]
pub fn and(left: Expr, right: Expr) -> Expr {
Expr::Binary(BinaryExpr::new(
Box::new(left),
Operator::And,
Box::new(right),
))
}

#[allow(dead_code)]
pub fn or(left: Expr, right: Expr) -> Expr {
Expr::Binary(BinaryExpr::new(
Box::new(left),
Operator::Or,
Box::new(right),
))
}
86 changes: 86 additions & 0 deletions vortex-expr/src/expressions.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
use vortex_dtype::FieldName;
use vortex_scalar::Scalar;

use crate::expression_fns::binary_expr;
use crate::operators::Operator;

#[derive(Clone, Debug, PartialEq)]
pub enum Expr {
/// A binary expression such as "duration_seconds == 100"
Binary(BinaryExpr),

/// A named reference to a qualified field in a dtype.
Field(FieldName),

/// True if argument is NULL, false otherwise. This expression itself is never NULL.
IsNull(Box<Expr>),

/// A constant scalar value.
Literal(Scalar),

/// Additive inverse of an expression. The expression's type must be numeric.
Minus(Box<Expr>),

/// Negation of an expression. The expression's type must be a boolean.
Not(Box<Expr>),
}

impl Expr {
// binary logic

pub fn and(self, other: Expr) -> Expr {
binary_expr(self, Operator::And, other)
}

pub fn or(self, other: Expr) -> Expr {
binary_expr(self, Operator::Or, other)
}

// comparisons

pub fn eq(self, other: Expr) -> Expr {
binary_expr(self, Operator::EqualTo, other)
}

pub fn not_eq(self, other: Expr) -> Expr {
binary_expr(self, Operator::NotEqualTo, other)
}

pub fn gt(self, other: Expr) -> Expr {
binary_expr(self, Operator::GreaterThan, other)
}

pub fn gt_eq(self, other: Expr) -> Expr {
jdcasale marked this conversation as resolved.
Show resolved Hide resolved
binary_expr(self, Operator::GreaterThanOrEqualTo, other)
}

pub fn lt(self, other: Expr) -> Expr {
binary_expr(self, Operator::LessThan, other)
}

pub fn lt_eq(self, other: Expr) -> Expr {
binary_expr(self, Operator::LessThanOrEqualTo, other)
}

// misc
pub fn is_null(self) -> Expr {
Expr::IsNull(Box::new(self))
}

pub fn minus(self) -> Self {
Expr::Minus(Box::new(self))
}
}

#[derive(Clone, Debug, PartialEq)]
pub struct BinaryExpr {
pub left: Box<Expr>,
pub op: Operator,
pub right: Box<Expr>,
}

impl BinaryExpr {
pub fn new(left: Box<Expr>, op: Operator, right: Box<Expr>) -> Self {
Self { left, op, right }
}
}
8 changes: 8 additions & 0 deletions vortex-expr/src/lib.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
extern crate core;

mod display;
mod expression_fns;
pub mod expressions;
mod literal;
pub mod operators;
pub mod scalar;
Loading