Async IPC #307
Merged
Async IPC #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatesn
commented
May 10, 2024
|
|
||
| let inner = futures_util::stream::unfold(self, move |mut reader| async move { | ||
| match reader.next().await { | ||
| Ok(Some(array)) => Some((Ok(array.to_static()), reader)), |
There was a problem hiding this comment.
This to_static call is what allows us to use a regular futures::Stream instead of a LendingStream.
Honestly, I think I'd rather figure out buffer re-use and refactor ArrayView to not have borrowed values instead of switching over to LendingStream and losing out on the entire ecosystem e.g. StreamExt.
robert3005
reviewed
May 11, 2024
robert3005
reviewed
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented for both pure futures (e.g. Tokio) as well as MonoIO for IO-uring support.