Make DType::Struct a struct #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
reviewed
Apr 30, 2024
| #[cfg_attr(feature = "serde", derive(::serde::Serialize))] | ||
| pub struct CompositeID(&'static str); | ||
|
|
||
| impl CompositeID { |
There was a problem hiding this comment.
Given pr title I am surprised to see these changes here. Can we change the pr title or make separate pr?
|
I'm going to close this until we figure out what to do with Composite DTypes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to store e.g. a DType::Struct instead of just a DType when we want to ensure we have a struct dtype.
There are lots of FLUPs here related to #174