Named child arrays #1710
Merged
Named child arrays #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
reviewed
Dec 18, 2024
vortex-array/src/data/viewed.rs
Outdated
|
|
||
| #[allow(dead_code)] | ||
| pub fn named_children(&self) -> Vec<(String, ArrayData)> { | ||
| let mut collector = NamedChildrenCollector::default(); |
There was a problem hiding this comment.
can we also add this to Owned and ArrayData similar to what we do for children() ?
There was a problem hiding this comment.
In theory we only need to add it to ArrayData. We move the impl to Owned/Viewed if it gets big and we don't want to inline it, but it only needs to be pub(super)
a10y
approved these changes
Dec 18, 2024
| } | ||
|
|
||
| impl NamedChildrenCollector { | ||
| pub fn children(self) -> Vec<(String, ArrayData)> { |
There was a problem hiding this comment.
into_inner is probably a bit more idiomatic name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.