-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REE infers length from ends array #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will reopen this later, need to bring back some more scalar_at impls |
lwwmanning
approved these changes
Apr 3, 2024
possible now that #160 has merged 🥳 |
This PR introduces a panic when running bench compress, investigating.
|
robert3005
added a commit
that referenced
this pull request
Apr 4, 2024
This reverts commit 1a5c2fe.
jdcasale
added a commit
that referenced
this pull request
Apr 4, 2024
…y respect patches (#194) before: Issue: #193 #147 uncovered that we did not respect patches in scalar_at calculations, causing a panic when REE ends arrays were bitpacked with patches. After: * We have a validity is implementation for BitPackedArray * ScalarAtFn for BitPackedArray no longer ignores patches * benches/compress no longer panics * flatten respects fill_value --------- Co-authored-by: Will Manning <[email protected]> Co-authored-by: Robert Kruszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19