-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up alignment #115
Comments
Related to #7 |
Current plan:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to decide to what level of fidelity we want to enforce alignment. Currently, we enforce nothing but then occasionally run into interop issues with Arrow. To work around these, we ensure that Arrow does the allocation (e.g., on the VarBinView builder). This is kludgy and error-prone.
An alternative option would be to require or encourage all buffers allocated by the project to be aligned to some value (e.g., the platform-specific
arrow_buffer::alloc::ALIGNMENT
, or the max of that and 64/128 bytes, etc).If we require all of our buffers to be aligned, then that will imply copying unaligned
Vec
s passed by users (arrow-rs
doesn't copy), so we should probably make it obvious & less ergonomic to do so.The text was updated successfully, but these errors were encountered: