Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure alignment for vortex-buffer #454

Closed
robert3005 opened this issue Jul 12, 2024 · 3 comments
Closed

Ensure alignment for vortex-buffer #454

robert3005 opened this issue Jul 12, 2024 · 3 comments

Comments

@robert3005
Copy link
Member

Right now when creating Bytes based buffers we lose the alignment information. There has been no movement on issue to allow this tokio-rs/bytes#437 which would mean that unless allocator_api is stable this is unlikely to happen.

@gatesn
Copy link
Contributor

gatesn commented Dec 17, 2024

I came across an aligned-buffer and aligned-buffer-pool as part of the Rkyv utilities repo: https://crates.io/crates/aligned-buffer

I will try to rebuild vortex-buffer (along with mutable and P-typed versions) around this crate and then we can move away from Arrow buffers, Bytes buffers, Vec<u8> and Vec<PType::NATIVE>.

@gatesn gatesn changed the title Replace tokio Bytes with Bytes implementation that can have arbitrary alignment Ensure alignment for vortex-buffer Dec 17, 2024
@gatesn
Copy link
Contributor

gatesn commented Dec 17, 2024

There is an open question though around how we handle unaligned buffers coming in from external systems.

@gatesn
Copy link
Contributor

gatesn commented Dec 17, 2024

Dupe of #115

@gatesn gatesn closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants