Skip to content

Commit

Permalink
Remove ALP compare (#1603)
Browse files Browse the repository at this point in the history
Can add it back when it works

See #1602
  • Loading branch information
gatesn authored Dec 6, 2024
1 parent 6e9d779 commit d8c60f0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 147 deletions.
139 changes: 0 additions & 139 deletions encodings/alp/src/alp/compute/compare.rs

This file was deleted.

10 changes: 2 additions & 8 deletions encodings/alp/src/alp/compute/mod.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
mod compare;

use vortex_array::compute::{
filter, scalar_at, slice, take, CompareFn, ComputeVTable, FilterFn, FilterMask, ScalarAtFn,
SliceFn, TakeFn, TakeOptions,
filter, scalar_at, slice, take, ComputeVTable, FilterFn, FilterMask, ScalarAtFn, SliceFn,
TakeFn, TakeOptions,
};
use vortex_array::validity::ArrayValidity;
use vortex_array::variants::PrimitiveArrayTrait;
Expand All @@ -13,10 +11,6 @@ use vortex_scalar::Scalar;
use crate::{match_each_alp_float_ptype, ALPArray, ALPEncoding, ALPFloat};

impl ComputeVTable for ALPEncoding {
fn compare_fn(&self) -> Option<&dyn CompareFn<ArrayData>> {
Some(self)
}

fn filter_fn(&self) -> Option<&dyn FilterFn<ArrayData>> {
Some(self)
}
Expand Down

0 comments on commit d8c60f0

Please sign in to comment.