Skip to content

Commit

Permalink
ci: actually run with wasm32-unknown-unknown (#1648)
Browse files Browse the repository at this point in the history
I thought setting the toolchain was enough but apparently not.

I also fixed a couple of small WASM32 compile errors that had snuck in
since last week.
  • Loading branch information
a10y authored Dec 11, 2024
1 parent bcc5f92 commit b4c5846
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
with:
targets: wasm32-unknown-unknown
- name: Rust Build vortex
run: cargo build -p vortex
run: cargo build -p vortex --target wasm32-unknown-unknown


build-all:
Expand Down
2 changes: 1 addition & 1 deletion vortex-io/src/dispatcher/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use std::task::Poll;

use futures::channel::oneshot;
use futures::FutureExt;
#[cfg(not(any(feature = "compio", feature = "tokio")))]
#[cfg(not(any(feature = "compio", feature = "tokio", target_arch = "wasm32")))]
use vortex_error::vortex_panic;
use vortex_error::{vortex_err, VortexResult};

Expand Down
3 changes: 1 addition & 2 deletions vortex-io/src/dispatcher/wasm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
use std::future::Future;

use futures::channel::oneshot;
use futures::channel::oneshot::Receiver;
use vortex_error::{vortex_panic, VortexResult};
use wasm_bindgen_futures::wasm_bindgen::__rt::Start;

use crate::{Dispatch, JoinHandle as VortexJoinHandle};
use super::{Dispatch, JoinHandle as VortexJoinHandle};

/// `Dispatch`able type that is available when running Vortex in the browser or other WASM env.
#[derive(Debug, Clone)]
Expand Down

0 comments on commit b4c5846

Please sign in to comment.