add impl TryFrom<Scalar> for $T

spiraldb · Jun 5, 2024 · 89ec624 · 89ec624
1 parent c527cb5
commit 89ec624
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/vortex-datetime-parts/src/compute.rs b/vortex-datetime-parts/src/compute.rs
@@ -222,18 +222,10 @@ mod test {
         let local = decode_to_localdatetime(&date_times.into_array()).unwrap();
 
         let elem0: i64 = scalar_at(&local.timestamps(), 0)
-            .unwrap()
-            .value()
-            .as_pvalue()
-            .unwrap()
             .unwrap()
             .try_into()
             .unwrap();
         let elem1: i64 = scalar_at(&local.timestamps(), 1)
-            .unwrap()
-            .value()
-            .as_pvalue()
-            .unwrap()
             .unwrap()
             .try_into()
             .unwrap();

diff --git a/vortex-scalar/src/primitive.rs b/vortex-scalar/src/primitive.rs
@@ -123,6 +123,14 @@ macro_rules! primitive_scalar {
                     .ok_or_else(|| vortex_err!("Can't extract present value from null scalar"))
             }
         }
+
+        impl TryFrom<Scalar> for $T {
+            type Error = VortexError;
+
+            fn try_from(value: Scalar) -> Result<Self, Self::Error> {
+                <$T>::try_from(&value)
+            }
+        }
     };
 }