less

spiraldb · Mar 28, 2024 · 39b0832 · 39b0832
1 parent f5d51ce
commit 39b0832
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/vortex-array/Cargo.toml b/vortex-array/Cargo.toml
@@ -40,3 +40,7 @@ vortex-schema = { path = "../vortex-schema" }
 
 [dev-dependencies]
 criterion = { workspace = true }
+
+[[bench]]
+name = "search_sorted"
+harness = false
diff --git a/vortex-array/src/compute/search_sorted.rs b/vortex-array/src/compute/search_sorted.rs
@@ -115,13 +115,6 @@ impl<S: IndexOrd<T> + Len + ?Sized, T> SearchSorted<T> for S {
     }
 }
 
-impl<T: Array> IndexOrd<Scalar> for T {
-    fn index_cmp(&self, idx: usize, elem: &Scalar) -> Option<Ordering> {
-        let scalar_a = scalar_at(self, idx).ok()?;
-        scalar_a.partial_cmp(elem)
-    }
-}
-
 impl IndexOrd<Scalar> for &dyn Array {
     fn index_cmp(&self, idx: usize, elem: &Scalar) -> Option<Ordering> {
         let scalar_a = scalar_at(*self, idx).ok()?;
@@ -131,13 +124,8 @@ impl IndexOrd<Scalar> for &dyn Array {
 
 impl<T: PartialOrd> IndexOrd<T> for [T] {
     fn index_cmp(&self, idx: usize, elem: &T) -> Option<Ordering> {
-        self[idx].partial_cmp(elem)
-    }
-}
-
-impl<T: Array> Len for T {
-    fn len(&self) -> usize {
-        T::len(self)
+        // SAFETY: Used in search_sorted_by same as the standard library. The search_sorted ensures idx is in bounds
+        unsafe { self.get_unchecked(idx) }.partial_cmp(elem)
     }
 }