Forbid for encoding with wrapping

spiraldb · Jun 24, 2024 · 139687c · 139687c
1 parent 1fb03ae
commit 139687c
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/encodings/fastlanes/src/for/compress.rs b/encodings/fastlanes/src/for/compress.rs
@@ -42,6 +42,15 @@ impl EncodingCompression for FoREncoding {
             return None;
         }
 
+        match_each_integer_ptype!(parray.ptype(), |$P| {
+            let min: $P = parray.statistics().compute_min()?;
+            let max: $P = parray.statistics().compute_max()?;
+            let _subbed = max.wrapping_sub(min);
+            if max.wrapping_sub(min) < max {
+                return None;
+            }
+        });
+
         Some(self)
     }
 
@@ -200,9 +209,11 @@ mod test {
 
     #[test]
     fn test_overflow() {
-        // Create a range offset by a million
-        let array = PrimitiveArray::from((i8::MIN..i8::MAX).collect_vec());
-        let compressed = FoREncoding {}
+        let array = PrimitiveArray::from((i8::MIN..=i8::MAX).collect_vec());
+        assert!(FoREncoding
+            .can_compress(array.array(), &CompressConfig::default())
+            .is_none());
+        let compressed = FoREncoding
             .compress(array.array(), None, Compressor::new(&ctx()))
             .unwrap();
         let compressed = FoRArray::try_from(compressed).unwrap();