Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spiral/monolog-bridge] Adding the ability to configure the Monolog messages format #994

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC?
New feature? ✔️
Issues #989

What was changed

Added the ability to configure the Monolog messages format via environment variable MONOLOG_FORMAT.
We can't add the format parameter to the configuration file because it is needed in the logRotate method, which is used to add handlers to the configuration file:
https://github.com/spiral/app/blob/master/app/src/Application/Bootloader/LoggingBootloader.php#L20

@msmakouz msmakouz added this to the 3.9 milestone Sep 14, 2023
@msmakouz msmakouz self-assigned this Sep 14, 2023
@msmakouz msmakouz linked an issue Sep 14, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.28% ⚠️

Comparison is base (cc53ed1) 83.95% compared to head (0651d8b) 83.67%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #994      +/-   ##
============================================
- Coverage     83.95%   83.67%   -0.28%     
- Complexity     6087     6093       +6     
============================================
  Files           800      801       +1     
  Lines         17141    17197      +56     
============================================
- Hits          14390    14389       -1     
- Misses         2751     2808      +57     
Files Changed Coverage Δ
...ridge/Monolog/src/Bootloader/MonologBootloader.php 0.00% <0.00%> (ø)
.../Bridge/Monolog/tests/Config/MonologConfigTest.php 0.00% <0.00%> (ø)
src/Bridge/Monolog/tests/RotateHandlerTest.php 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 66bc902 into spiral:master Sep 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Monolog ability to set log.rotate format
2 participants